You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While moving -c/--stdout in a more visible place is straightforward and correctly done in this PR,
the situation is less clear for -q/--quiet.
I think it makes more sense to keep -q alongside -v, as they both impact the same thing (i.e. the amount of verbosity). Other -h help screens agree with this principle, with the exception of those which follow the alphabetical order strictly.
So we could also bring -v along with -q? But now it introduces another question: which options deserves to be tagged "important", and be promoted to first help screen (as opposed to the more advanced and complete -H). We can't just promote everything blindly, because if everything is important, nothing is.
In order to keep this PR short, I would separate the 2 issues, so that -c/--stdout can be validated and merged without delay nor uncertainty related to other less obvious topics.
While moving -c/--stdout in a more visible place is straightforward and correctly done in this PR,
the situation is less clear for -q/--quiet. I think it makes more sense to keep -q alongside -v, as they both impact the same thing (i.e. the amount of verbosity). Other -h help screens agree with this principle, with the exception of those which follow the alphabetical order strictly.
So we could also bring -v along with -q? But now it introduces another question: which options deserves to be tagged "important", and be promoted to first help screen (as opposed to the more advanced and complete -H). We can't just promote everything blindly, because if everything is important, nothing is.
In order to keep this PR short, I would separate the 2 issues, so that -c/--stdout can be validated and merged without delay nor uncertainty related to other less obvious topics.
Makes sense! I've updated pr and title to only promote -c. Let me know if there's anything else :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote -c to be standard option displayed by -h #4455
Thanks for the suggestion @tats-u !